check prerequisites 1 / 2 #2046
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- git - grunt-cli - github-api connection warn if local mongo-db not found
lib/installHelpers.js
Outdated
| method: 'GET' | ||
| }, function(error, response) { | ||
| if (error) { | ||
| result.errors.push(`Failed to´connect to ${url}`); |
There was a problem hiding this comment.
Random character ´ in error string.
install.js
Outdated
| if(error) { | ||
| return handleError(error, 1, 'Failed to get the latest framework version. Check package.json.'); | ||
| return handleError(error, 1, 'Not all required pre-requisites fulfilled. Please check install guides.'); |
There was a problem hiding this comment.
Suggest removing required. A prerequisite is required by nature.
lib/installHelpers.js
Outdated
| @@ -578,3 +579,71 @@ function error(msg) { | |||
| function isSilent() { | |||
| return process.env.SILENT; | |||
| } | |||
|
|
|||
| /** | |||
| * Manually collect all misisng prerequisites | |||
lib/installHelpers.js
Outdated
| ], result, function(error) { | ||
| if (error) return callback(error); | ||
| if (result.errors.length) { | ||
| return callback(new Error(result.errors.join(', '))); |
There was a problem hiding this comment.
Suggest a line break between errors.
There was a problem hiding this comment.
have tried this, will format it oddly. I can do however if you like.
There was a problem hiding this comment.
This is the output for me in Windows if changed to .join('\n'):
There was a problem hiding this comment.
Looks good.
Agree that it would look nicer with each error on a separate line.
Missing the following pre-requisites, please check install guides:
- git
- grunt
- ffmpeg
- failed to connect to github.com
| }); | ||
| } | ||
|
|
||
| function checkLocalMongoDbConnection(result, callback) { |
There was a problem hiding this comment.
This doesn't actually check the connection does it? Maybe needs a rename to avoid any confusion.
| checkLocalMongoDbConnection, | ||
| checkFfmpegInstalled | ||
| ], | ||
| 'Missing the following optional dependecies, please check install guides:', |
|
Replaced with PR 2059. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #880
Checks known prerequisites in an early stage and exits if not met:
Warns if not met:
[ ] local mongodb not foundPart 2 will be to check if a connection to database can be established once it is configured. This will be based on #2015