Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

copy / move editor array item #2019

Closed

Conversation

lc-thomasberger
Copy link
Member

No description provided.

@taylortom
Copy link
Member

Did you have a look at the sortable plugin linked to in the original issue?

@taylortom taylortom removed this from the 0.6.0 Scaffold rewrite milestone Jul 20, 2018
@lc-thomasberger
Copy link
Member Author

No, I have not seen this. Looks good, will have to test it.

@lc-thomasberger
Copy link
Member Author

@taylortom This makes use of a library. It works pretty well on IE but I am not so sure about how frequently it gets maintained.
I have not tested implementing the snippet.

What do others think? Does it make sense to add another library for drag-and-drop that is currently only used by the editor?

@taylortom
Copy link
Member

Yeah, good point. I'll look into how easy it is to do this with jQuery UI.

@taylortom
Copy link
Member

Have done a prototype here

@tomgreenfield
Copy link
Contributor

Love the draggable prototype, @taylortom. Default values, reset button and printing of nested objects need close attention.

@lc-thomasberger
Copy link
Member Author

lc-thomasberger commented Aug 1, 2018

@taylortom yes this is very nice. I made some styling tweaks:

  • added a drop-placeholder
  • styled the dragged element
  • limit drag-direction in y axis

Happy to commit or PR this into your PR. We can also make your PR as the base and add the duplicate feature.

itemsdnd

https://github.com/adaptlearning/adapt_authoring/tree/itemDnd-styling

@taylortom
Copy link
Member

Thanks for that, looks really nice :) Happy with whatever makes it easiest for you.

@lc-thomasberger
Copy link
Member Author

Superseded by #2034

@taylortom taylortom deleted the feature/copyMoveItem branch September 4, 2018 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants