Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop throwing error if repo update check failed #1768

Merged
merged 4 commits into from
Nov 8, 2017

Conversation

taylortom
Copy link
Member

Fixes #1763

@taylortom taylortom added this to the 0.4.1 Bugfixes milestone Oct 30, 2017
Copy link
Contributor

@tomgreenfield tomgreenfield left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Script is erroring:
$ node install
D:\adapt_authoring\lib\installHelpers.js:220
      logger.warn(`Couldn't check latest version of ${repoName}\n${error}`);
      ^

ReferenceError: logger is not defined
    at Request._requestHandler [as _callback] (D:\adapt_authoring\lib\installHelpers.js:220:7)
    at self.callback (D:\adapt_authoring\node_modules\request\request.js:186:22)
    at emitOne (events.js:96:13)
    at Request.emit (events.js:188:7)
    at Request.onRequestError (D:\adapt_authoring\node_modules\request\request.js:878:8)
    at emitOne (events.js:96:13)
    at ClientRequest.emit (events.js:188:7)
    at TLSSocket.socketErrorListener (_http_client.js:310:9)
    at emitOne (events.js:96:13)
    at TLSSocket.emit (events.js:188:7)
    at connectErrorNT (net.js:1025:8)
    at _combinedTickCallback (internal/process/next_tick.js:80:11)
    at process._tickDomainCallback (internal/process/next_tick.js:128:9)

@dancgray
Copy link
Member

@taylortom This is still falling over with no internet. Is that expected?

@taylortom
Copy link
Member Author

Apologies @dancgray, have amended a broken if

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants