Fix invalid zip issue with plugin upload #1733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes adaptlearning#1732
|
Thanks for this. We actually moved over to unzip2 at some point in the past, but we ended up going back for reasons I can't remember -- the issues may have been resolved in later unzip2 releases, so definitely worth testing again. Can you also switch the base to develop please? |
|
Base changed - I was sure that I did that when I made the request but I must have missed it.... |
lc-thomasberger
approved these changes
Feb 8, 2018
canstudios-louisem
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1732
related: https://www.npmjs.com/package/unzip2