Fix asset preview in place #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomgreenfield
approved these changes
Aug 11, 2017
* develop: (29 commits) Remove test data both before and after tests Add extended timeout to after() in addition to before() Reinstate longer timeout Add grunt to deps Temporarily disable casperjs tests Update package.json prior for next release Update mocha Tidy up mocha config Switch to use grunt test task Only show logger errors Remove log Update config files Amend testData Alter tests to stop error messages Move data folder cleanup and rename various things for readability Rename references to tenant record results for clarity fix tests, upgrade should tests now allways start with a clean db Add comment Fix removeDirectory ...
taylortom
requested review from
lc-thomasberger,
canstudios-nicolaw and
canstudios-louisem
canstudios-nicolaw
approved these changes
Aug 15, 2017
canstudios-louisem
approved these changes
Aug 16, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1695.