Issue/1502 #1691
Issue/1502 #1691
Conversation
lib/tenantmanager.js
Outdated
| } | ||
|
|
||
| return callback(new Error('No matching tenant record found')); | ||
| return self.updateTenant({ '_id': results[0]._id }, { _isDeleted: true }, callback); |
There was a problem hiding this comment.
results is no longer defined?
|
Tests should be working smoothly now |
|
The tests are all passing for me, I have noticed I get the following output when I run them
I just wanted to check this is something we are expecting/aware of? |
|
@canstudios-nicolaw that's because of this test. We can set up the logger to mute all messages during the tests if we want? (log level is set here). |
|
Ok I am happy as long as we understand where it is coming from :) It feels a bit dangerous to mute all messages in case we miss something in future. |
|
Have updated the test script to use the grunt 'test' task, thus removing the need for a makefile. |
| @@ -357,7 +349,6 @@ module.exports = function(grunt) { | |||
| } | |||
| }); | |||
|
|
|||
| grunt.registerTask('test', ['mochaTest'/*, 'casperjs'*/]); | |||
There was a problem hiding this comment.
Should we update the package.json's test command as it curently does make test not grunt test. Im not sure how much it matters really at Can we all use php storm's mocha test runner to run unit tests.
There was a problem hiding this comment.
The latest package.json should use grunt test
There was a problem hiding this comment.
Ah nice for some reason i missed you had changed it.
|
@canstudios-louisem you're right, I just knew if I waited to do a separate PR, I'd likely forget 😅 |
|
that's why i added a reminder months a go :) #1649 |
#1502