Use variables for font weights #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lc-thomasberger
approved these changes
Aug 1, 2017
|
Any chance we could chuck this in for 0.4.0 @taylortom? |
taylortom
reviewed
Aug 10, 2017
|
|
||
| h6 { | ||
| font-weight:200; | ||
| h1, h2, h3, h4, h5, h6 { |
There was a problem hiding this comment.
Any reason we're changing these to use a single weight? (appreciate we weren't importing the specified weights)
There was a problem hiding this comment.
- Revert header tags to bold weighting, removing the need for multiple overrides
We have been overriding in several places just to get back to the (browser) default of bold weights for headings, making things a little convoluted. Also, the lighter weights have never been rendered from the offset, rather falling back to normal/400.
P.S./N.B./furthermore: this PR doesn't actually change any of the interface, I've added in styles where necessary to keep the UI the same as before.
taylortom
approved these changes
Aug 10, 2017
canstudios-louisem
approved these changes
Aug 10, 2017
* develop: (57 commits) Remove test data both before and after tests Add extended timeout to after() in addition to before() Reinstate longer timeout Add grunt to deps Temporarily disable casperjs tests Update package.json prior for next release Update mocha Tidy up mocha config Switch to use grunt test task Fix heading Only show logger errors Remove log Update config files Amend testData Alter tests to stop error messages Move data folder cleanup and rename various things for readability Rename references to tenant record results for clarity fix tests, upgrade should tests now allways start with a clean db Add comment ...
* develop: Bump timeout for Travis
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves Create LESS variables for font weights #1638
Two named font weight variables:
Revert header tags to bold weighting, removing the need for multiple overrides