Fix create user error #1680
Merged
Fix create user error #1680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dancgray
approved these changes
Jul 26, 2017
taylortom
approved these changes
Jul 27, 2017
tomgreenfield
approved these changes
Jul 27, 2017
plugins/auth/local/index.js
Outdated
| LocalAuth.prototype.internalRegisterUser = function (user, cb) { | ||
| if (!user.email || !user.password || !user.retypePassword) { | ||
| LocalAuth.prototype.internalRegisterUser = function(retypePasswordRequired, user, cb) { | ||
| if (!user.email || !user.password) { | ||
| return cb(new auth.errors.UserRegistrationError('email, password and retyped password are required!')); |
There was a problem hiding this comment.
Just to note this error message could now be misleading when there's no retyped password field:
There was a problem hiding this comment.
Good spot I'll fix that now
plugins/auth/local/index.js
Outdated
| if (user.password !== user.retypePassword) { | ||
| return cb(new auth.errors.UserRegistrationError('password and retyped password must match!')); | ||
| } | ||
| } else { |
There was a problem hiding this comment.
Cheers for amending. Can we lose the else here, unless I'm missing something?
There was a problem hiding this comment.
Yes we can! 2 ticks
tomgreenfield
approved these changes
Jul 28, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1677