-
Notifications
You must be signed in to change notification settings - Fork 292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes #1631 #1632
Merged
Merged
Fixes #1631 #1632
Changes from 6 commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
dbdb9bf
Update header format
chucklorenz ebd3396
fixes #1611 (#1612)
danielstorey ad20ac5
Fixes #1631
danielstorey 6233767
Merge branch 'develop' into danielstorey/issue/1631
taylortom 8b80239
Merge pull request #2 from taylortom/danielstorey/issue/1631
danielstorey d6c56a9
Fix reference to collection
taylortom 4b7d46f
Move var declaration to avoid undefined value
taylortom e8ffd1b
Fix var name
taylortom File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -79,30 +79,32 @@ define(function(require) { | |
renderComponentList: function() { | ||
Origin.trigger('editorComponentListView:removeSubviews'); | ||
// _.each(this.collection, function(componentType) { | ||
|
||
this.collection.each(function(componentType) { | ||
var properties = componentType.get('properties'); | ||
if (properties && properties.hasOwnProperty('._supportedLayout')) { | ||
var supportedLayout = properties.hasOwnProperty('._supportedLayout').enum; | ||
if (properties && properties.hasOwnProperty('_supportedLayout')) { | ||
var supportedLayout = properties._supportedLayout.enum; | ||
var availablePositions = _.clone(this.availablePositions); | ||
|
||
// Prune the available positions | ||
if (_.indexOf(supportedLayout, 'half-width') == -1) { | ||
this.availablePositions.left = false; | ||
this.availablePositions.right = false; | ||
availablePositions.left = false; | ||
availablePositions.right = false; | ||
} | ||
|
||
if (_.indexOf(supportedLayout, 'full-width') == -1) { | ||
this.availablePositions.full = false; | ||
availablePositions.full = false; | ||
} | ||
} | ||
|
||
this.$('.editor-component-list-sidebar-list').append(new EditorPageComponentListItemView({ | ||
model: componentType, | ||
availablePositions: this.availablePositions, | ||
_parentId: this.model.get('_parentId'), | ||
$parentElement: this.$parentElement, | ||
parentView: this.parentView, | ||
searchTerms: componentType.get('displayName').toLowerCase() | ||
}).$el); | ||
this.$('.editor-component-list-sidebar-list').append(new EditorComponentListItemView({ | ||
model: componentType, | ||
availablePositions: availablePositions, | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Like that?¿ |
||
_parentId: this.model.get('_parentId'), | ||
$parentElement: this.$parentElement, | ||
parentView: this.parentView, | ||
searchTerms: componentType.get('displayName').toLowerCase() | ||
}).$el); | ||
}, this); | ||
}, | ||
|
||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Getting an error when I try to add a component. I don't think the view should have been renamed here?