Fixes export to only allow one zip on the server per user #1080
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The wWrite stream overwrites any existing files with the same name
|
Maybe need to revaluate this in conjunction with #1091 |
|
@dancgray could you have a look at this? I think it's still a valid issue. |
|
@taylortom this is still a valid issue. Single zip per user should be fine, it would only be a problem if users share login details and export source for different courses at the same time. It will reduce disk space compared with current setup. |
| }); | ||
| } | ||
| }); | ||
| } else { | ||
| res.statusCode = 401; | ||
| return res.json({ | ||
| return res.status(401).json({ | ||
| success: false, | ||
| message: app.polyglot.t('app.errorusernoaccess') | ||
| }); | ||
| } | ||
| }); | ||
| }); | ||
| // TODO probably needs to be moved to download route |
There was a problem hiding this comment.
This is a good time to address this TODO. Were calling it download it should probably be part of the download lib and route.
* develop: (537 commits) ignore .vscode and package-lock.json supress npm warnings article view now generated after article model saved Fixes #1772 Amend check to allow undefined data Switch to local log func Stop throwing error if repo update check failed Fix version check Add override for removal of list items Handle response errors better amend title for clarity following code review better help text, more consistent use of '?' in titles remove some ARIA labels that were not used add the core properties _isVisible and _isHidden add missing 'instruction' property to article & block improve usability through better titles/help text Master changes (#1741) Fix bug with recursive function call Remove testing header Update CHANGELOG for release 0.4.0 (#1739) Enchancements to install/update (#1726) Amend contentModel._children to allow for arrays fixes 1474 ... # Conflicts: # frontend/src/core/editor/global/views/editorView.js # lib/helpers.js # plugins/output/adapt/index.js
* develop: (80 commits) update Check if user is course owner Require modules before plugins Change to ensureDirSync refactor to set scrollTop after all animations are completed hook into transition end event instead of post render Fixes #1906 Allow MongoDB authentication in install script Fix modules define Fix globalData Make sure we load the plugin Fix issue with merge Save isVisible and isHidden on blocks and components Fix context menu for page Move plugin folder to modules Refactor for readability Update comments Fix plugin code broken in refactor Persist sort prefs indefinitely Remove config-sample.json ... # Conflicts: # frontend/src/modules/editor/global/views/editorView.js
canstudios-louisem
approved these changes
Mar 22, 2018
lc-thomasberger
approved these changes
Mar 23, 2018
dancgray
approved these changes
Mar 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is then overwritten with each export.
Fixes #1056.