Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Installation npm vunerability warnings - Braces / Windows 10 #2420

Closed
TimFrance opened this issue Aug 23, 2019 · 4 comments
Closed

Installation npm vunerability warnings - Braces / Windows 10 #2420

TimFrance opened this issue Aug 23, 2019 · 4 comments

Comments

@TimFrance
Copy link

Expected Behaviour

No npm vunerability warnings

Actual Behaviour

Run npm install [email protected] to resolve 1 vulnerability
SEMVER WARNING: Recommended action is a potentially breaking change
Low Regular Expression Denial of Service
Package braces
Dependency of migrate-mongoose
Path migrate-mongoose > babel-cli > chokidar > anymatch >
micromatch > braces
More info https://npmjs.com/advisories/786
Manual Review
Some vulnerabilities require your attention to resolve
Visit https://go.npm.me/audit-guide for additional guidance

Steps to Reproduce

There appears to be two versions of the brace package in the Adapt installation
\node_modules\anymatch\node_modules\braces\package.json shows [email protected]
\node_modules\braces\package.json shows [email protected]

According to https://www.npmjs.com/advisories/786
Versions of braces prior to 2.3.1 are vulnerable to Regular Expression Denial of Service (ReDoS). Untrusted input may cause catastrophic backtracking while matching regular expressions. This can cause the application to be unresponsive leading to Denial of Service.
Remediation
Upgrade to version 2.3.1 or higher.

So it appears that the older version of braces at \node_modules\anymatch\node_modules\braces is the source of the problem.

see also #2419
#1745
@LouiseMcMahon

Versions

  • Authoring Tool Version: 0.9.0
  • Framework Version: 2.4.0
  • Node.js Version: v10.16.3
  • MongoDB Compass Community Version: 1.19.6
  • Operating System: Windows 10
  • Browser: Chome Version 76.0.3809.100 (Official Build) (64-bit)
@oliverfoster
Copy link
Member

Hi Tim, could you please read and respond to my comments on your original issue before you make any more?

You have clearly identified a third degree module which has outstanding security warnings, as I had mentioned in my original comment, we have no control over those modules.

We will not be suppressing the security vulnerabilities.

@oliverfoster
Copy link
Member

Please add these sub items to your original issue. They are the same issue and you have yet to respond to my original message.

@TimFrance
Copy link
Author

TimFrance commented Aug 23, 2019 via email

@oliverfoster
Copy link
Member

No worries 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants