Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dashboard paging broken after deleting courses #2253

Closed
taylortom opened this issue Feb 27, 2019 · 2 comments
Closed

Dashboard paging broken after deleting courses #2253

taylortom opened this issue Feb 27, 2019 · 2 comments
Assignees
Labels
I: major High priority bugs which don't immediately impact the user S: merged Completed, reviewed, and merged issues T: bug
Milestone

Comments

@taylortom
Copy link
Member

taylortom commented Feb 27, 2019

Expected Behaviour

On deleting a course, we need to do a fresh fetch to make sure the full amount of courses are shown.

Actual Behaviour

It's possible to break the paging by deleting enough courses to hide the scrollbar.

Steps to Reproduce

  1. Make sure you have enough courses to cause paging
  2. Resize browser to fit a small number of courses (I had two rows of three)
  3. Delete courses until you're down to a single row
  4. Note no more courses are fetched, page must be refreshed to fix
@taylortom taylortom added T: bug I: major High priority bugs which don't immediately impact the user labels Feb 27, 2019
@taylortom taylortom added this to the Suggested Next milestone Feb 27, 2019
@lc-thomasberger
Copy link
Member

I am not sure if we should stick to the infinite scrolling approach.
Especially for Assets I think it is more usable to have pagination links. As this gives you a better overview about the amount of pages/ items are available. It is also much easier to navigate through a collection. A good example is github's issue page.

I think we should move to pagination links for Assets and Dashboard.

@taylortom taylortom self-assigned this Mar 27, 2019
@taylortom taylortom added the S: in-progress Issues currently being worked on - leave these be! label Apr 2, 2019
@taylortom
Copy link
Member Author

Also see: #1824

taylortom added a commit that referenced this issue Apr 2, 2019
@taylortom taylortom added S: awaiting-review Completed issues waiting on reviews and removed S: in-progress Issues currently being worked on - leave these be! labels Apr 2, 2019
@taylortom taylortom added S: merged Completed, reviewed, and merged issues and removed S: awaiting-review Completed issues waiting on reviews labels Apr 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
I: major High priority bugs which don't immediately impact the user S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Development

No branches or pull requests

2 participants