Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Callback is not defined on import error. #1980

Closed
dancgray opened this issue Jun 5, 2018 · 0 comments
Closed

Callback is not defined on import error. #1980

dancgray opened this issue Jun 5, 2018 · 0 comments
Assignees
@dancgray
Labels
S: merged Completed, reviewed, and merged issues T: bug
Milestone
0.5.0 Import/Export

Comments

@dancgray
Copy link
Member

dancgray commented Jun 5, 2018

Expected Behaviour

Appropriate error message is returned to user.

Actual Behaviour

Get:
ReferenceError: next is not defined

This is because next is not defined here

Steps to Reproduce

One way to reproduce this is to upload a zip which exceeds the maxFileSize.

Versions

  • Authoring Tool Version: v5-rc1
  • Framework Version: --
  • Operating System: all
  • Browser: --
@dancgray dancgray added the T: bug label Jun 5, 2018
@dancgray dancgray added this to the 0.5.0 Import/Export milestone Jun 5, 2018
@dancgray dancgray mentioned this issue Jun 5, 2018
Merged
@dancgray dancgray added the S: in-progress Issues currently being worked on - leave these be! label Jun 6, 2018
@dancgray dancgray self-assigned this Jun 6, 2018
taylortom added a commit that referenced this issue Jun 13, 2018
@taylortom
Merge pull request #1981 from adaptlearning/issue/1980
2bd8966 
use correct callback for import, fixes #1980
@lc-thomasberger lc-thomasberger added the S: merged Completed, reviewed, and merged issues label Jun 13, 2018
@taylortom taylortom removed the S: in-progress Issues currently being worked on - leave these be! label Jun 20, 2018
@snyk-bot snyk-bot mentioned this issue Feb 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dancgray dancgray

Labels
S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Milestone
0.5.0 Import/Export
Development

No branches or pull requests
3 participants
@taylortom @dancgray @lc-thomasberger