Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Find broken in Ace editor #1928

Closed
canstudios-louisem opened this issue Mar 22, 2018 · 2 comments
Closed

Find broken in Ace editor #1928

canstudios-louisem opened this issue Mar 22, 2018 · 2 comments
Assignees
@canstudios-louisem
Labels
D: easy Straightforward issues, small time commitment I: minor Low, impact, low priority bugs S: merged Completed, reviewed, and merged issues T: bug
Milestone
0.5.0 Import/Export

Comments

@canstudios-louisem
Copy link
Contributor

Expected Behaviour

when a code editor window is active CTRL + F should open a search box

Actual Behaviour

No search box is open

Steps to Reproduce

  1. Create a course.
  2. Go to project settings.
  3. Click into the custom css area.
  4. press CTRL + F note no search box appears in the css area.

Versions

  • Authoring Tool Version: 0.4.1
  • Browser: Chrome
@canstudios-louisem
Copy link
Contributor Author

Fix in the attached patch.txt file.

@canstudios-louisem canstudios-louisem added T: bug D: easy Straightforward issues, small time commitment labels Mar 22, 2018
@canstudios-louisem canstudios-louisem mentioned this issue Mar 22, 2018
Merged
@canstudios-louisem canstudios-louisem self-assigned this Mar 22, 2018
@canstudios-louisem canstudios-louisem added S: awaiting-review Completed issues waiting on reviews I: minor Low, impact, low priority bugs labels Mar 22, 2018
@canstudios-louisem
Copy link
Contributor Author

This is a regression from 0.3.0

@canstudios-louisem canstudios-louisem added S: merged Completed, reviewed, and merged issues and removed S: awaiting-review Completed issues waiting on reviews labels Mar 23, 2018
taylortom added a commit that referenced this issue Apr 5, 2018
@taylortom
Merge branch 'develop' into issue/1486
f7f0dea 
* develop: (111 commits)
  update archive dependecy
  Fixes: #1928
  Fix and refactor helper
  update
  Check if user is course owner
  Require modules before plugins
  Change to ensureDirSync
  refactor to set scrollTop after all animations are completed
  hook into transition end event instead of post render
  Fixes #1906
  Allow MongoDB authentication in install script
  Fix modules define
  Fix globalData
  Make sure we load the plugin
  Fix issue with merge
  Save isVisible and isHidden on blocks and components
  Fix context menu for page
  Move plugin folder to modules
  Refactor for readability
  Update comments
  ...

# Conflicts:
#	frontend/src/core/helpers.js
#	frontend/src/modules/assetManagement/index.js
#	frontend/src/modules/editor/contentObject/index.js
#	frontend/src/modules/editor/course/index.js
taylortom added a commit that referenced this issue Apr 9, 2018
@taylortom
Merge branch 'develop' into issue/1116
7a36411 
* develop: (94 commits)
  update archive dependecy
  Fixes: #1928
  Fix and refactor helper
  update
  Check if user is course owner
  Require modules before plugins
  Change to ensureDirSync
  refactor to set scrollTop after all animations are completed
  hook into transition end event instead of post render
  Fixes #1906
  Allow MongoDB authentication in install script
  Fix modules define
  Fix globalData
  Make sure we load the plugin
  Fix issue with merge
  Save isVisible and isHidden on blocks and components
  Fix context menu for page
  Move plugin folder to modules
  Refactor for readability
  Update comments
  ...

# Conflicts:
#	plugins/output/adapt/index.js
taylortom added a commit that referenced this issue Apr 24, 2018
@taylortom
Merge branch 'develop' into issue/1761
8563d4a 
* develop: (35 commits)
  Update CONTRIBUTING.md
  Fix typo
  minor code improvements
  added review
  ignore colorLabel attribute from being used in the editor schemas
  Re-add hack for gmcq/mcq dependency
  less improvements and use vars to define colors
  add translation and description text to color label popup
  Log plugin install error
  Add extra log funcs
  Fix function
  Use strict equality
  update archive dependecy
  Don't fail on plugin install error
  add _colorLabel to component schema
  Fixes: #1928
  Fix and refactor helper
  styling
  update originView to set colorlabel attribute
  add colorLabelPopupView
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@canstudios-louisem canstudios-louisem

Labels
D: easy Straightforward issues, small time commitment I: minor Low, impact, low priority bugs S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Milestone
0.5.0 Import/Export
Development

No branches or pull requests
1 participant
@canstudios-louisem