Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Router logs 'no index.js found' for any MODULE_NOT_FOUND when loading routes #1853

Closed
taylortom opened this issue Jan 24, 2018 · 0 comments
Closed
Assignees
Labels
D: easy Straightforward issues, small time commitment S: merged Completed, reviewed, and merged issues T: bug

Comments

@taylortom
Copy link
Member

When Router attempts to load a route (by require-ing index.js), if a MODULE_NOT_FOUND error is thrown, a generic 'no index.js found' message is logged. Depending on where the error's thrown, this could be caused by something else (e.g. missing local file, missing node module).

Steps to Reproduce

  1. Require a node module that doesn't exist in a routes/index.js file.

Versions

  • Authoring Tool Version: 0.4.0
@taylortom taylortom added T: bug D: easy Straightforward issues, small time commitment labels Jan 24, 2018
@taylortom taylortom self-assigned this Jan 24, 2018
taylortom added a commit that referenced this issue Jan 24, 2018
@taylortom taylortom added this to the 0.5.0 milestone Jan 24, 2018
@taylortom taylortom added the S: awaiting-review Completed issues waiting on reviews label Jan 24, 2018
taylortom added a commit that referenced this issue Jan 24, 2018
@canstudios-louisem canstudios-louisem added S: merged Completed, reviewed, and merged issues and removed S: awaiting-review Completed issues waiting on reviews labels Mar 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D: easy Straightforward issues, small time commitment S: merged Completed, reviewed, and merged issues T: bug
Projects
None yet
Development

No branches or pull requests

2 participants