contentObjectModel getChildren function broken #1719
Labels
Milestone
Comments
taylortom
added a commit
that referenced
this issue
Aug 31, 2017
taylortom
added a commit
that referenced
this issue
Oct 17, 2017
* updated from feedback changed icon to paintbrush * fixes 1474 * Amend contentModel._children to allow for arrays Fix #1719 * Enchancements to install/update (#1726) * can upgrades to upgrade and install script * removed version.json * fix issues caused by removing version.json fix pacakge.json version number. fix issue that stopped automatic upgrade added error catching to gitub api calls * Merge lib/application.js changes from canstudios/latest-release * Add refactored file * Refactor common code into helper file * Move framework & authoring git code into helper * Switch to use helper function Also reduce other duplication * Fix issue with framework folder path * Switch comparison to use semver * Refactor, and switch to use configuration module * Add spinner * Add delegate function to check for update data * Adjust spinner code * Make log a bit more user-friendly * Amend code style * Remove all dependencies on version.json * Remove whole framework folder before clone * Fix import errors * Remove comments * Reword message * Refactor * Start install refactor * Amend imports * Update style * Refactor * Fix broken references * Add newlines * Add temporary callback * Move config items to point of ref, as need to make use of dynamic vars * Set configResults * Refactor tenant code * Add bracket for readability * Remove line * Update tenantmanager to use local framework * Add missing import * Fix to framework install * Keep config.frameworkRevision for now * Add logs * Add error checks * Add custom directory * Fix application update check * Add missing import * Fix error handling * Update functions to use opts values * Disable logging for now * Remove framework install This is now done by tenantmanager when setting up master tenant * Add frontend build function to helpers * Update logs * Amend colouring * Hide exec logs * Add error handling * Move spinner code to helpers * Move exit code to helpers * Abstract input code * Refactor functions for more general use * Add missing bits * Update logs for readability * Fix logic * Remove extraneous code * Add helpful error for GitHub API limit error Amend some other logs for readability * Add missing error var * Update log messages * Amend to use log wrapper * Add spinner to install * Fix issue with halted install process * Fix upgrade version check issue * Allow framework version to be ‘locked’ in config.json Requires ‘framework’ attribute, can be 1, 2, or 3 figures (e.g. ‘1’, ‘1.1’ or ‘1.1.1’) * Allow undefined frameworkRevision value * Add dependency * Set env var to silence install output * Remove adapt_framework folder from .gitignore * Amend in-line with review by @tomgreenfield * Remove unused functions * Refactor * Fix error handling * Fix typos * Add config.json install overrides Also refactor input configs * Switch to use writeJSON * Add input validators/transforms * Refactor for readability * Fix error bug * Fix error check * Remove .env file generation as we don’t support foreman * Update prompt dev to allow password replace * Remove .env and .vagrant * Fix config output * Update feedback texts * Remove reference to version.json * Fix issue with framework install directory * Removed unused lines * Move into single applyEachSeries * Don’t modify existing object * Pass opts to bowermanager * Fix issue with framework plugin isntall * Refactor code * Change prompt.delimiter to match install script * Fix issue with undefined masterTenantID * Make SMTP input optional * Remove redundant code * Tidy output logs * Move init * Stop newline after passwords * Move installHelpers * Move further up * Uncouple function from framework lock * Move input code to installHelpers * Update instructional text * Refactor error handling code * Fix issue with authoring update erroring on git fetch * Move log * Rewrite for readability * Make revision input optional But must specify one… * Refactor for error handling * Fix framework update Now updateRepos always does a fetch Resets to remote/branch * Fix updateRepo to allow any valid revision * Remove logs * Remove node_modules before installing deps * Amend user instruction text * Fix typo * Use backticks * Amend logging * Update log * Fix issue with returning error after exec * Default framework URL to adaptlearning * Return error if trying to upgrade with custom repos * Refactor error handling code * Split up server config items to let us dynamically set rootUrl.default * Remove unused function * Switch processes to use remote name ‘origin’ * Fix config defaults * Return data with callback * Switch spinner library due to issue on windows * Fix broken var reference * Update log for usability * Allow for config.json value * Fix whitespace * Remove log from config.json install * Add db connection check * Move out of async.race due to execution time * Reduce animation framerate * Fix error handler * Update CHANGELOG for release 0.4.0 (#1739) * Add release notes * Fix formatting * Update date * Update titles * Reword opening paragraph * Remove INSTALL.md content * Add further changes * Remove testing header * Fix bug with recursive function call Was called infinitely if value wasn’t undefined
tomgreenfield
pushed a commit
that referenced
this issue
May 9, 2018
* Add initial version of framework import * fix merge issues in output plugin * Import front end plugin * Add export from @taylortom plus metadata export * Add AT import * Refactor * framework plugin import * Add source validation and asset import * enable only included plugins and add tags to course * Clean up and add sort consentobjects to source import * remove decompress * Add course assets check Also removes toggle extension * Clean up and fix menu order, asset tag issues and import button * fix return issues * add constants to paths * Find import lang folder and reset import buttons on fail Framework import now takes first lang folder it finds. Folder name is used for config._defaultLanguage * Move export button to sidebar and rename * update archiver * Move import to modules folder * Move framework import into modules * Add changes required for integration with refactor * Fix missing imports * Replace string * fixes 1474 * Amend contentModel._children to allow for arrays Fix #1719 * Remove AT import * Tidy and remove unnecessary comments * async v2 breaks async.auto calls auto task functions now always take the callback as the last argument. If a task has dependencies, the results object will be passed as the first argument. https://github.com/caolan/async/blob/master/CHANGELOG.md#breaking-change s. * Use new version check function * semver no longer error's with invalid version * Remove code added in error by merge * fix events * Remove TODO comments See issue #1788 * Update bower plugin to latest and surface addPackage for framework import * remove fs rename fs -> fse require helper * path join causes issues on Windows as it uses `\` as a path delimiter. * refactor, update button after form validation. Only show loading animation when the form is submitted. * Revert "remove fs" This reverts commit d049de9. * Don't fail if no plugins included * Allow user to specify asset folders If no folder entered checks assets, images, videos, audio automatically. * Add validation for user input asset folders * Tidy framework import frontend form Also clean user entered asset directories and log if not found. * Fix issue when plugin does not match framework version * Make export button consistent with preview and download * Remove devMode from export We now only have one type of export * Update labels * Merge CanStudios:export-import-assets and fix conflicts * Add more useful error message for bad export packages * Update label * Refactor error response as string * Move import button * Refactor to use async.apply * Add missing func * Update labels * Return early * Return early * Add return * Return early * Refactor to remove async.series * Fix whitespace * Refactor (mostly whitespace related) * Remove unused metadata funcs * Remove missing function reference * Refactor for readability * Fix callback reference * Fix attribute name * correct importsource.js callbacks and comments * remove duplicate function * import helpers tidy and lang file indentation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Since this has been changed to 'articles', this no longer allows the menu to render correctly, as it doesn't register other contentObjects as children.
The text was updated successfully, but these errors were encountered: