Localise page title, remove initialize function from models

adaptlearning · Aug 7, 2017 · 4c76ce2 · 4c76ce2
1 parent 9d4bc15
commit 4c76ce2
Show file tree

Hide file tree

Showing 8 changed files with 7 additions and 34 deletions.
diff --git a/frontend/src/core/models/articleModel.js b/frontend/src/core/models/articleModel.js
@@ -6,11 +6,7 @@ define(function(require) {
     urlRoot: '/api/content/article',
     _parent: 'contentObjects',
     _siblings: 'articles',
-    _children: 'blocks',
-
-    initialize: function(options) {
-      // TODO intentional override?
-    }
+    _children: 'blocks'
   });
 
   return ArticleModel;

diff --git a/frontend/src/core/models/blockModel.js b/frontend/src/core/models/blockModel.js
@@ -28,11 +28,7 @@ define(function(require) {
       '_extensions',
       'themeSettings',
       '_onScreen'
-    ],
-
-    initialize: function() {
-      // TODO interntional override?
-    }
+    ]
   });
 
   return BlockModel;

diff --git a/frontend/src/core/models/componentModel.js b/frontend/src/core/models/componentModel.js
@@ -27,11 +27,7 @@ define(function(require) {
       'version',
       'themeSettings',
       '_onScreen'
-    ],
-
-    initialize: function() {
-      // TODO intentional override?
-    }
+    ]
   });
 
   return ComponentModel;

diff --git a/frontend/src/core/models/componentTypeModel.js b/frontend/src/core/models/componentTypeModel.js
@@ -9,10 +9,6 @@ define(function(require) {
 
     comparator: function(model) {
       return model.get('displayName');
-    },
-
-    initialize: function() {
-      // TODO intentional override?
     }
   });
 

diff --git a/frontend/src/core/models/contentObjectModel.js b/frontend/src/core/models/contentObjectModel.js
@@ -12,12 +12,7 @@ define(function(require) {
     defaults: {
       _isSelected: false,
       _isExpanded: false
-    },
-
-    initialize: function() {
-
-    },
-
+    }
   });
 
   return ContentObjectModel;

diff --git a/frontend/src/core/models/courseModel.js b/frontend/src/core/models/courseModel.js
@@ -9,9 +9,6 @@ define(function(require) {
     _type: 'course',
     _children: 'contentObjects',
 
-    initialize : function(options) {
-    },
-
     getHeroImageURI: function () {
       if(Helpers.isAssetExternal(this.get('heroImage'))) {
         return this.get('heroImage');

diff --git a/frontend/src/core/models/extensionModel.js b/frontend/src/core/models/extensionModel.js
@@ -5,10 +5,7 @@ define(function(require) {
   var ExtensionModel = ContentModel.extend({
     urlRoot: '/api/extensiontype',
     idAttribute: '_id',
-    _type: 'extension',
-
-    initialize: function(){
-    }
+    _type: 'extension'
   });
 
   return ExtensionModel;

diff --git a/frontend/src/modules/editor/course/views/editorCourseEditView.js b/frontend/src/modules/editor/course/views/editorCourseEditView.js
@@ -77,8 +77,8 @@ define(function(require) {
 
       var contentObjectModel = new ContentObjectModel();
       contentObjectModel.save({
-        title: 'Page Title',
-        displayTitle: 'Page Title',
+        title: Origin.l10n.t('app.placeholdernewpage'),
+        displayTitle: Origin.l10n.t('app.placeholdernewpage'),
         _type: 'page',
         _courseId: model.get('_id'),
         _parentId: model.get('_id')