Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issue/1333 Added error abstraction #198

Merged
merged 2 commits into from
Oct 12, 2020
Merged

issue/1333 Added error abstraction #198

merged 2 commits into from
Oct 12, 2020

Conversation

oliverfoster
Copy link
Member

@oliverfoster oliverfoster commented Aug 5, 2020 •
edited by moloko
Loading

Fixes #1333
Fixes #1238

Added

  • Error objects with codes and error data
  • Default messages and translatable overrides
  • Used an _isCancellable: false notify to display CLIENT_COULD_NOT_CONNECT errors

image

@oliverfoster oliverfoster requested a review from moloko August 5, 2020 14:43
@oliverfoster oliverfoster self-assigned this Aug 5, 2020
@oliverfoster
Copy link
Member Author

There are also a series of other logs which may need to be translatable? like: https://github.com/adaptlearning/adapt-contrib-spoor/blob/master/js/scorm/wrapper.js#L75

oliverfoster
oliverfoster commented Aug 5, 2020
View reviewed changes
js/scorm/wrapper.js

if (!this.suppressErrors && (!this.logOutputWin || this.logOutputWin.closed) && confirm(`An error has occured:\n\n${_msg}\n\nPress 'OK' to view debug information to send to technical support.`)) {
if (!this.suppressErrors && (!this.logOutputWin || this.logOutputWin.closed) && confirm(`An error has occured:\n\n${message}\n\nPress 'OK' to view debug information to send to technical support.`)) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The classic popup pre/post-amble probably needs adding somewhere/how

@oliverfoster oliverfoster marked this pull request as ready for review August 17, 2020 08:50
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Aug 17, 2020
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

lc-alexanderbenesch
lc-alexanderbenesch approved these changes Oct 12, 2020
View reviewed changes
Copy link

@lc-alexanderbenesch lc-alexanderbenesch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@oliverfoster oliverfoster merged commit 80867e3 into master Oct 12, 2020
@oliverfoster oliverfoster deleted the issue/1333 branch October 12, 2020 09:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lc-alexanderbenesch lc-alexanderbenesch lc-alexanderbenesch approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@moloko moloko moloko approved these changes

Assignees

@oliverfoster oliverfoster

Labels
enhancement
Projects
None yet
Milestone
No milestone
5 participants
@oliverfoster @moloko @cahirodoherty-learningpool @lc-alexanderbenesch @olivermartinfoster