Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual item states rely on color alone #288

Closed
kirsty-hames opened this issue Dec 11, 2023 · 6 comments · Fixed by #301
Closed

Visual item states rely on color alone #288

kirsty-hames opened this issue Dec 11, 2023 · 6 comments · Fixed by #301

Comments

@kirsty-hames
Copy link
Contributor

kirsty-hames commented Dec 11, 2023

Subject of the issue

Visual progress of items is represented via .narrative__progress, see screenshot below for progress dots below image. Item states include default, selected and visited. The change in state is represented by color change only (see plugin and Vanilla styles). This information will be difficult or impossible to perceive for individuals with visual disabilities such as low vision or color blindness.
narrative

Expected behaviour

Provide a non-color dependent means of identifying current item (selected) and completed items. Some ideas below but please input with any thoughts or suggestions.

Selected state:
Increase the size of the progress item when selected.
progress_selected

Completed state:
Other presentation components display a tick icon for completed items, see screenshots below. Could do similar and display the completion tick within the progress item or as a separate icon over the Narrative image.

hotgraphic accordion
@kirsty-hames
Copy link
Contributor Author

What are peoples thoughts on the following suggestions?

1. Indicators remain small until visited

progress_small_1 progress_small_2

2. Keep indicators size uniform
progress_uniform_1
progress_uniform_2

Both options display a tick when visited and invert their colours when selected. The tick is displayed at @icon-size (1.5rem) for consistency with other component item visited ticks. This does mean that the indicators are larger than they currently are.

@oliverfoster
Copy link
Member

I quite like 2, I'm mildly worried about having too many items and what the indicators would do. Do you have thoughts?

@kirsty-hames
Copy link
Contributor Author

I quite like 2, I'm mildly worried about having too many items and what the indicators would do. Do you have thoughts?

See below for how the various layouts look with 10 items without any additional styling. "_hasNavigationInTextArea": true needs some consideration otherwise the indicators just wrap for standard layout.

Desktop view:
desktop

Medium breakpoint before single column stack:
before_breakpoint

Mobile view:
mobile

@oliverfoster
Copy link
Member

Is it best to keep the indicators below the image always, rather moving them with the navigation buttons?

@StuartNicholls
Copy link

Is it best to keep the indicators below the image always, rather moving them with the navigation buttons?

This actually gets requested a fair bit, so yeah, let's change it.

@StuartNicholls
Copy link

I prefer the smaller check marks, too

@kirsty-hames kirsty-hames self-assigned this Apr 11, 2024
@kirsty-hames kirsty-hames moved this from Awaiting Response to Assigned in adapt_framework: The TODO Board Apr 11, 2024
@kirsty-hames kirsty-hames moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Apr 16, 2024
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Apr 19, 2024
github-actions bot pushed a commit that referenced this issue Apr 19, 2024
# [7.9.0](v7.8.1...v7.9.0) (2024-04-19)

### Chore

* e2e tests on narrative component (Issue/280) (#299) ([748f3d4](748f3d4)), closes [#299](#299)

### New

* completion icon added to progress indicators (fixes #288)  (#301) ([f41ab76](f41ab76)), closes [#288](#288) [#301](#301)

### Upgrade

* Bump ip from 1.1.8 to 1.1.9 (#300) ([b2520b0](b2520b0)), closes [#300](#300)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants