Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_isMobileTextBelowImage back button issue #271

Closed
swashbuck opened this issue Jul 5, 2023 · 3 comments · Fixed by #272
Closed

_isMobileTextBelowImage back button issue #271

swashbuck opened this issue Jul 5, 2023 · 3 comments · Fixed by #272
Assignees

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Jul 5, 2023

Subject of the issue

When viewing on mobile with _isMobileTextBelowImage set to 'true'

  • The Back button is always disabled
  • The Next button is not disabled when reaching the last item.

Possibly related to adaptlearning/adapt-contrib-hotgraphic#278

back-disabled

Your environment

  • Framework 5.31.12
  • Narrative 7.4.9

Steps to reproduce

  1. On a Narrative, use _isMobileTextBelowImage: true
  2. View Narrative on a mobile device or at a mobile screen width with a non-mobile device.
  3. Click the Next button to go to item 2

Expected behaviour

Once item 2 is active, the Back button should be enabled.

Actual behaviour

Back button is not enabled.

@kirsty-hames
Copy link
Contributor

I can replicate the issue described but I think it's specific to instances where the item (image and text) is greater than the screen height. For example, I can replicate this on my iPhone SE but not on an iPhone XR. I can avoid the issue on iPhone SE if I scroll each item into view before selecting the 'next' button.

@swashbuck
Copy link
Contributor Author

I can replicate the issue described but I think it's specific to instances where the item (image and text) is greater than the screen height. For example, I can replicate this on my iPhone SE but not on an iPhone XR. I can avoid the issue on iPhone SE if I scroll each item into view before selecting the 'next' button.

That's odd. I wasn't able to reproduce the issue based on the heights. That said, I think I've fixed it now :)

@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Jul 11, 2023
github-actions bot pushed a commit that referenced this issue Jul 11, 2023
## [7.4.10](v7.4.9...v7.4.10) (2023-07-11)

### Fix

* Fix previous/next button states when using _isMobileTextBelowImage (fixes #271) ([ab28273](ab28273)), closes [#271](#271)
@github-actions
Copy link

🎉 This issue has been resolved in version 7.4.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants