Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fullscreen triggers the inview handler of the components underneath #304

Open
swashbuck opened this issue Sep 27, 2024 · 0 comments
Open
Labels

Comments

@swashbuck
Copy link
Contributor

swashbuck commented Sep 27, 2024

Subject of the issue

The fullscreen bug from adapt-contrib-framework #1478 ("making video fullscreen triggers the inview handler of the component underneath") does not seem to have been completely fixed or has stopped working with newer browsers.

This is the current fix:
https://github.com/adaptlearning/adapt-contrib-media/blob/master/libraries/mediaelement-fullscreen-hook.js

Your environment

  • FW 5.39.7
  • Media 6.7.3
  • Mac 14.7, Firefox 130.0.1

Steps to reproduce

  1. Place blocks with components set to inview completion immediately after a block with a Media component.
  2. Enter and exit fullscreen on the Media component.

Expected behaviour

inview components stay incomplete.

Actual behaviour

inview components are completed.

Screen recordings

In both examples below, I'm setting the component background color to pink once completed to assist with testing.

.component.is-complete {
  background: deeppink !important;
}

Example 1

Here, I immediately click on the fullscreen button and then exit. The subsequent Text component is immediately completed.

fullscreen1.mp4

Example 2

In this recording, I first play the video. Then, I enter and exit fullscreen mode five times. On the last time, the Text component is completed.

fullscreen2.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests

1 participant