-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Breaking: Upgrade MediaElement.js (fixes #298 #297 #232) #299
base: master
Are you sure you want to change the base?
Conversation
… it no longer exists
…earing when toggleCaptionsButtonWhenOnlyOne: true
… startLanguage to autoplayCaptionLanguage, move startVolume, partially fix mediaCaptionsChange
…rientation without scaling
…break playing on touch devices and may no longer be needed
I've noticed that Youtube isn't working either - The README does mention support is temperamental, but perhaps this should be properly documented as being removed like it is with Vimeo. |
Thanks, @simondate . I've added this to the PR notes above and have made it more clear in the readme. |
Ready for review. |
Fix #298 #297 #232
Breaking
Notable changes and deletions
speed
,jumpforward
andskipback
have moved to mejs plugins. Other plugins can be considered for inclusion in the future.MediaFeatures
object is now justFeatures
media
,node
, andinstance
. I've added documentation about this toonPlayerReady()
which is the success callback function.mediaElement.player
changed tomediaElement.options
.selectedTrack
has moved to theinstance
object mentioned above.Fix
Configuration changes to existing courses
None
Dependencies
Regression testing
The following fixes could use retesting. I could not find the original GitHub tickets for some of these.
delete hideTimeout
lines. The newbuildfullscreen()
inmediaelement-and-player.js
does not use this.Known issues