Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: alwaysShowControls default changed to true (fixes #276) #277

Merged
merged 2 commits into from
Oct 30, 2023
Merged

Fix: alwaysShowControls default changed to true (fixes #276) #277

merged 2 commits into from
Oct 30, 2023

Conversation

joe-allen-89
Copy link
Contributor

#276

Fix

@joe-allen-89 joe-allen-89 self-assigned this Oct 18, 2023
@joe-allen-89 joe-allen-89 linked an issue Oct 18, 2023 that may be closed by this pull request
Set alwaysShowControls to true by default #276
Closed
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 26, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

kirsty-hames
kirsty-hames approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@kirsty-hames kirsty-hames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected thanks

@kirsty-hames kirsty-hames merged commit 9658a30 into master Oct 30, 2023
1 check passed
@kirsty-hames kirsty-hames deleted the issue/276 branch October 30, 2023 17:08
github-actions bot pushed a commit that referenced this pull request Oct 30, 2023
@semantic-release-bot
Chore(release): 6.4.4 [skip ci]
a260aa6 
## [6.4.4](v6.4.3...v6.4.4) (2023-10-30)

### Fix

* alwaysShowControls default changed to true (fixes #276) (#277) ([9658a30](9658a30)), closes [#276](#276) [#277](#277)
@github-actions
Copy link

🎉 This PR is included in version 6.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

Assignees

@joe-allen-89 joe-allen-89

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set alwaysShowControls to true by default
4 participants
@joe-allen-89 @kirsty-hames @oliverfoster @cahirodoherty-learningpool