Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set alwaysShowControls to true by default #276

Closed
guywillis opened this issue Oct 9, 2023 · 1 comment · Fixed by #277
Closed

Set alwaysShowControls to true by default #276

guywillis opened this issue Oct 9, 2023 · 1 comment · Fixed by #277
Assignees
@joe-allen-89
Labels
enhancement released

Comments

@guywillis
Copy link
Contributor

guywillis commented Oct 9, 2023 •
edited
Loading

Subject of the enhancement

The media player controls, by default, do not display for the media player. A hover event is required to visually show the player controls. This means that if a user is to navigate through a page using the keyboard tab focus the elements within the controls are not visible but are focussed.

Screenshot 2023-10-09 at 10 28 43

Your environment

  • Master AT & FW

Expected behaviour

The player controls are shown by default to improve the visual accessibility of the media plugin. Each element of the control bar also has a focus state that is visible once the player controls are shown.

"_playerOptions": {
  "alwaysShowControls": true,
}
Screenshot 2023-10-09 at 10 29 41
@joe-allen-89 joe-allen-89 self-assigned this Oct 18, 2023
@joe-allen-89 joe-allen-89 moved this from New to Assigned in adapt_framework: The TODO Board Oct 18, 2023
@joe-allen-89 joe-allen-89 mentioned this issue Oct 18, 2023
Merged
@joe-allen-89 joe-allen-89 linked a pull request Oct 18, 2023 that will close this issue
Fix: alwaysShowControls default changed to true (fixes #276) #277
Merged
@joe-allen-89 joe-allen-89 moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Oct 18, 2023
kirsty-hames pushed a commit that referenced this issue Oct 30, 2023
@joe-allen-89
Fix: alwaysShowControls default changed to true (fixes #276) (#277)
9658a30 
* Fix: alwaysShowControls default changed to true

* example updated
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Oct 30, 2023
github-actions bot pushed a commit that referenced this issue Oct 30, 2023
@semantic-release-bot
Chore(release): 6.4.4 [skip ci]
a260aa6 
## [6.4.4](v6.4.3...v6.4.4) (2023-10-30)

### Fix

* alwaysShowControls default changed to true (fixes #276) (#277) ([9658a30](9658a30)), closes [#276](#276) [#277](#277)
@github-actions
Copy link

🎉 This issue has been resolved in version 6.4.4 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joe-allen-89 joe-allen-89

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix: alwaysShowControls default changed to true (fixes #276) adaptlearning/adapt-contrib-media
2 participants
@guywillis @joe-allen-89