Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix devcontainer setup #2675

Merged
merged 2 commits into from
Dec 1, 2023
Merged

Fix devcontainer setup #2675

merged 2 commits into from
Dec 1, 2023

Conversation

Robert-Steiner
Copy link
Member

@Robert-Steiner Robert-Steiner commented Dec 1, 2023

Description

  • fixes the devcontainer setup
  • use apt-get instead of apt explanation
  • moved vscode related settings into customizations object (settings and extensions are not allowed anymore)

Explanation

When i tried to run the project in the dev container, the postCreateCommand was failing with PermissionErrors. Strictly speaking poetry was not able to install any dependency. The problem was that we install the python, poetry, etc. as a root user and run the postCreateCommand as flwr-vscode user but without sudo. Based on python-poetry/poetry#5928 it seems that with an older version of poetry it is possible to run without sudo but I'm not entirely sure about that.

@tanertopal tanertopal enabled auto-merge (squash) December 1, 2023 15:30
@tanertopal tanertopal merged commit c4b68b0 into main Dec 1, 2023
27 checks passed
@tanertopal tanertopal deleted the improve-vscode-dev-container-docs branch December 1, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants