Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Export 'replaceInFile' namespace. #173

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Export 'replaceInFile' namespace. #173

merged 1 commit into from
Oct 27, 2023

Conversation

kukko
Copy link
Contributor

@kukko kukko commented Oct 16, 2023

I fixed the issue, so the replaceInFile namespace wasn't exported.

I reported this issue in the #172 issue.

@kukko
Copy link
Contributor Author

kukko commented Oct 16, 2023

Would you be so kind and participate with the repository in Hacktoberfest, so it would count as one of my PRs for the event?

@adamreisnz
Copy link
Owner

adamreisnz commented Oct 16, 2023

Sure, how do I do that? Should I wait with merging this PR until I have joined?

@kukko
Copy link
Contributor Author

kukko commented Oct 20, 2023

The site of Hacktoberfest states the following:
Add the “hacktoberfest” topic to your repository to opt-in to Hacktoberfest and indicate you’re looking for contributions.

But you can simply merge the PR if you think it is okay. Hacktoberfest now don't give nice rewards, so it isn't necessary for me. But even without it I would create this PR.

Do you think that the PR is acceptable and necessary?

@lornz
Copy link

lornz commented Oct 27, 2023

Definitely necessary for me! Otherwise it fails on build.
This PR fixes that.

Would be great if you could merge it.

@adamreisnz
Copy link
Owner

Thank you, have merged it in

@adamreisnz adamreisnz merged commit 6f698cf into adamreisnz:main Oct 27, 2023
@adamreisnz
Copy link
Owner

Has been released as 7.0.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants