Updates to fix 2025.1 issues #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ADeadPixel
commented
Jan 10, 2025
ADeadPixel
commented
- Consolidated imports
- Utilized the new Home Assistant Constant Enums
- Updated manifest to new version number
- Consolidated imports - Utilized the new Home Assistant Constant Enums - Updated manifest to new version number
|
This is one of my first PRs for a HACS project so I'm not sure what the procedures are. I updated the manifest to a new version but I'm not sure if that was right |
|
I tested this in my HA instance and it loaded the integration after a restart |
|
Thanks. What sort of constant gets naming updates? |
|
Pretty much everything that could be a unit now follows the pattern of UnitOfX where X is the domain for that unit. Like UnitOfVolume or UnitOfTime. Is there anything else needed to cut a release for this? |
|
I just tested this on my installation and it works! Thanks a million! <3 You da MVP! |
|
Great Works! Thank You!!!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.