Shellcheck and markdown lint

adamoutler · Aug 9, 2023 · df3d274 · df3d274
1 parent 675835d
commit df3d274
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 7 deletions.
diff --git a/argonOne/run.sh b/argonOne/run.sh
@@ -176,7 +176,7 @@ until false; do
 
   set +e
 
-  if [ $previousFanLevel != $fanLevel ]; then
+  if [ "${previousFanLevel}" != "${fanLevel}" ]; then
     #based on current position, and quiet mode, we can set the name and percentage of fanspeed.
     case $fanLevel in
       1)

diff --git a/argonOneClassic/run.sh b/argonOneClassic/run.sh
@@ -129,8 +129,8 @@ until false; do
 
   fanPercent=$((value_a*value+value_b))
   set +e
-  if [ $previousFanPercent != $fanPercent ]; then
-    actionLinear "${fanPercent}" "${cpuTemp}" "${CorF}"
+  if [ "${previousFanPercent}" != "${fanPercent}" ]; then
+  actionLinear "${fanPercent}" "${cpuTemp}" "${CorF}"
     test $? -ne 0 && fanPercent=previousFanPercent
     previousFanPercent=$fanPercent
   fi

diff --git a/argonOneLinear/README.md b/argonOneLinear/README.md
@@ -31,10 +31,12 @@ fanPercent=$((value_a*value+value_b))
 
 ## Support
 
-First, look in the Logs tab of the Addon's page in HA to see if i2c was set up properly, or for any other errors.
+First, look in the Logs tab of the Addon's page in HA to see if i2c was set up properly, or for any other
+ errors.
 
-Also, enable the "Log current temperature every 30 seconds" setting and look in the logs to see what the speed is. The fan is noisy and you
-might not be able to hear different speeds, but logging will verify any changes.
+Also, enable the "Log current temperature every 30 seconds" setting and look in the logs to see what the
+ speed is. The fan is noisy and you might not be able to hear different speeds, but logging will verify
+ any changes.
 
 Need support? Click [here](https://community.home-assistant.io/t/argon-one-active-cooling-addon/262598/8).
 Try to be detailed about your feedback.

diff --git a/argonOneLinear/run.sh b/argonOneLinear/run.sh
@@ -158,7 +158,7 @@ until false; do
 
   fanPercent=$((value_a*value+value_b))
   set +e
-  if [ $previousFanPercent != $fanPercent ]; then
+  if [ "${previousFanPercent}" != "${fanPercent}" ]; then
     actionLinear "${fanPercent}" "${cpuTemp}" "${CorF}"
     test $? -ne 0 && fanPercent=previousFanPercent
     previousFanPercent=$fanPercent