Rebase and update S3 config #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tilosp-bot <[email protected]>
Signed-off-by: tilosp-bot <[email protected]>
Run update.sh
Signed-off-by: tilosp-bot <[email protected]>
Signed-off-by: Adam Jenkins <[email protected]>
- usepath defaults to false (and is deprecated by AWS) - autocreate is not used/necessary by the objectstorage code (always tries to create) Signed-off-by: Stephen Cuppett <[email protected]>
adamjenkins1
requested changes
Aug 26, 2020
adamjenkins1
added a commit
that referenced
this pull request
Aug 26, 2020
* Run update.sh Signed-off-by: tilosp-bot <[email protected]> * Run update.sh Signed-off-by: tilosp-bot <[email protected]> * Run update.sh Signed-off-by: tilosp-bot <[email protected]> * Adds ability to configure S3 object stores via environment variables Signed-off-by: Adam Jenkins <[email protected]> * Updates objectstore autoconfiguration to match server defaults - usepath defaults to false (and is deprecated by AWS) - autocreate is not used/necessary by the objectstorage code (always tries to create) Signed-off-by: Stephen Cuppett <[email protected]> * Dropping NULL check Co-authored-by: tilosp-bot <[email protected]> Co-authored-by: Tilo Spannagel <[email protected]> Co-authored-by: Adam Jenkins <[email protected]> Signed-off-by: Adam Jenkins <[email protected]>
adamjenkins1
added a commit
that referenced
this pull request
Aug 26, 2020
Signed-off-by: Adam Jenkins <[email protected]> Rebase and update S3 config (#1) * Run update.sh Signed-off-by: tilosp-bot <[email protected]> * Run update.sh Signed-off-by: tilosp-bot <[email protected]> * Run update.sh Signed-off-by: tilosp-bot <[email protected]> * Adds ability to configure S3 object stores via environment variables Signed-off-by: Adam Jenkins <[email protected]> * Updates objectstore autoconfiguration to match server defaults - usepath defaults to false (and is deprecated by AWS) - autocreate is not used/necessary by the objectstorage code (always tries to create) Signed-off-by: Stephen Cuppett <[email protected]> * Dropping NULL check Co-authored-by: tilosp-bot <[email protected]> Co-authored-by: Tilo Spannagel <[email protected]> Co-authored-by: Adam Jenkins <[email protected]> Signed-off-by: Adam Jenkins <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's a rebase + all updates suggested in the PR.