Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change the 'error' can not identify by if #48

Closed
wants to merge 1 commit into from

Conversation

Mqhong
Copy link
Contributor

@Mqhong Mqhong commented May 9, 2016

Change the 'error' can not identify by if

SwiftR line 375 to 385

may there is a bug in swift—— if the parameters‘s type are AnyObject and the value is 'nil' , the if judgement not work.

Change the 'error' can not identify by if
@adamhartford
Copy link
Owner

Thanks. I think I'd like to fix it like this...

let error = json["error"] as AnyObject?

Let me know if you have any concerns with that.

adamhartford added a commit that referenced this pull request May 17, 2016
@adamhartford
Copy link
Owner

Fixed in v0.10.5.

@Mqhong
Copy link
Contributor Author

Mqhong commented May 17, 2016

It was great to your approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants