-
Notifications
You must be signed in to change notification settings - Fork 118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
core: remove deprecated gulp-util dependency #213
core: remove deprecated gulp-util dependency #213
Conversation
1 similar comment
example/fail.js
Outdated
@@ -3,7 +3,7 @@ | |||
// npm install gulp gulp-eslint | |||
|
|||
const gulp = require('gulp'); | |||
const gulpUtil = require('gulp-util'); | |||
const log = require('fancy-log'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you rename this to fancyLog
? I prefer explicitness.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done ;)
1 similar comment
@shinnn |
test/util.js
Outdated
@@ -216,7 +216,7 @@ describe('utility methods', () => { | |||
it('should default to gutil.log', () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
shouldn't the test message be it('should default to fancyLog, () => {
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the jsDoc should also be updated where [writable=gulp-util.log]
is specified
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, what @ninbryan said. Good catch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ninbryan Good catch, thanks!
1 similar comment
1 similar comment
@shinnn I also updated the |
[Unrelated to this "remove gulp-util" PR] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add v4.0.2 changelog.
@shinnn I updated |
1 similar comment
No. Just ignore @demurgos's comment, I've already deleted it though. |
Sorry for my comment about the lock file update. The use or not of lock files has no clear answer and it was not the place for this PR to discuss it. @mjeanroy |
CHANGELOG.md
Outdated
@@ -1,5 +1,9 @@ | |||
# Changelog | |||
|
|||
## 4.0.2 | |||
|
|||
* Remove deprecated [`gulp-util`](https://github.com/gulpjs/gulp-util) dependency and use individual modules instead. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the last .
for consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
Hi,
Since
gulp-util
has been deprecated, this PR replacegulp-util
with alternative individual modules. Please see: https://github.com/gulpjs/gulp-util