Optimize item loading with a delay #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With an approximation of over 150 items in the pointshop, the Garry's Mod game client will start hitching, because too many 'DPointShopItem' objects are being created at once. This optimization creates a 50ms delay, when each 'DPointShopItem' object is created. It allows the rest of the GUI to continue loading before all the items have completed. Hitching is reduced by approximately 80% and loading times are also reduced. This should theoretically triple the number of possible items, without an extended freeze period.
stickz
changed the title
|
When testing this further, I found that a 50ms initial delay and a 15ms delay for each item thereafter works better. This achieves the same result, while loading the pointshop over three times faster than before! |
|
1 year later |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With an approximation of over 150 items in the pointshop, the Garry's Mod game client will start hitching, because too many 'DPointShopItem' objects are being created at once. This optimization creates a 50ms delay, between creating each 'DPointShopItem' object. It allows the rest of the GUI to continue loading before all the items have completed. Hitching is reduced by approximately 80% and loading times are also reduced. This should theoretically triple the number of possible items, without an extended freeze period.