Use generic response type for trigger_client_event response parameter and return type. #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mypy was complaining when I tried to do something like this:
The
mypy
error:Now, I realise that this is partially due to my
mypy
configuration (and also that I probably didn't really need to assign the return value to that same variable), but this highlights that the return type annotation isn't precise enough. We should expect the return type to be the same subclass ofHttpResponseBase
as theresponse
argument.