Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid serialization for lists of unions #33

Merged
merged 1 commit into from
May 29, 2020

Conversation

lovasoa
Copy link
Collaborator

@lovasoa lovasoa commented May 23, 2020

Fixes #32

@codecov
Copy link

codecov bot commented May 23, 2020

Codecov Report

Merging #33 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master       #33   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            2         2           
  Lines           67        69    +2     
  Branches         5         5           
=========================================
+ Hits            67        69    +2     
Impacted Files Coverage Δ
src/marshmallow_union/__init__.py 100.00% <100.00%> (ø)
tests/test_union.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58bfc9f...78c654c. Read the comment docs.

@rllin
Copy link

rllin commented May 29, 2020

👍 to merging this fix!

@lovasoa lovasoa merged commit 4821724 into adamboche:master May 29, 2020
lovasoa added a commit that referenced this pull request May 30, 2020
@ammerzon ammerzon mentioned this pull request Jun 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_serialize ignores the given value
2 participants