-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[julia/es] Fix typos in Spanish Julia #580
Conversation
Also, the title of the last commit is wrong. It's supposed to be "back to ruby from julia". |
First off, you can edit the message of your last commit made with command:
But because you have already pushed the commit online, you would have to do a force push (-f flag) to reset the message on your repo (Be careful when using -f !! But because this is your repo, chances are others have not pulled your branch and made updates to it so you are safe to do it in this case):
After that your changes on your repo will be updated here. To answer your question about the file markdown being declared as Ruby, the list of supported languages for Github markdown does not list Julia so that must be the reason that Ruby is used. |
@levibostian Thanks. Should I also rebase on top of origin/master? |
It looks like https://github.com/adambard/learnxinyminutes-site is using https://github.com/jayferd/rouge for syntax coloring. It appears that rouge doesn't have a lexer for julia yet. |
@ggarza Nice research. It looks like Ruby is the best we are going to do at the moment. Yes, doing a rebase is always a good idea. Do this before you make pull requests to this project for sure. |
@@ -159,7 +158,7 @@ b[end] # => 6 | |||
# separados por punto y coma. | |||
matrix = [1 2; 3 4] # => 2x2 Int64 Array: [1 2; 3 4] | |||
|
|||
# Añadir cosas a la final de una lista con push! y append! | |||
# Añadir cosas al final de una lista con push! y append! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reading this change in English (Google translated) you changed "the" to "1". Translation might be off, but it sounds like it was not supposed to be changed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the translation is off.
To my ear, "al final" sounded better than "a la final." They're equivalent to "at the end" and "to the end."
I think I've changed my mind, though. "A la final," which is equivalent to "to the end" sounds better after thinking about the English translation.
@levibostian Thanks for looking this over! |
@ggarza I will look over the rest soon and make comments. Thank you for the cooperation as I am reading over the code with a translator. Who knows how accurate the translations are, so thank you for answering my concerns and being patient with me. Great work by the way making these fixes! You seem to know your Spanish. |
@levibostian Doing a good job :). |
@ggarza I reviewed the rest of the changes. After some questions getting answered and potentially fixing some parts, it is all ready to go in! I am excited about this merge, going to make it much better of a reference! So many great fixes here. |
Quick correction: We use a rouge fork at https://github.com/adambard/rouge for syntax highlighting, so we can include a few extra lexers that are too half-assed for jayferd to merge into the main fork. Pull requests welcome! |
@levibostian Tell me what you think and I'll push some changes and maybe do a rebase. |
@Nami-Doc @levibostian Ok. I made the changes. Thanks for reviewing. |
@ggarza Thank you VERY much for all the work! Great fixes here! |
[julia/es] Fix typos in Spanish Julia
I fixed some typos and changed the language in the Julia Spanish language version. I hope that somebody, who uses technical Spanish more than I do, takes a look at it.
Also, does the code that colors the source code understand julia by any chance? At present, the language is declared to be ruby.