Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit is not running on Python 3.12 #31

Open
makermelissa opened this issue Oct 26, 2023 · 4 comments · Fixed by #32 or #33
Open

pre-commit is not running on Python 3.12 #31

makermelissa opened this issue Oct 26, 2023 · 4 comments · Fixed by #32 or #33

Comments

@makermelissa
Copy link
Collaborator

Github Actions switch to Python 3.12 today and now workflows fail. I opened an issue with pre-commit here: pre-commit/pre-commit#3041

For the time being, we should probably lock it to python 3.11 until the issue is resolved.

@makermelissa
Copy link
Collaborator Author

Ok, they closed it saying virtualenv is too old. It sounds like the real fix is to start using venv now.

@dhalbert
Copy link
Contributor

It is not clear to me where we are using virtualenv instead of venv. I'd like to open up a different specific issue for that if that's a change to make.

@makermelissa
Copy link
Collaborator Author

Not fixed yet. It's still failing because https://github.com/adafruit/workflows-circuitpython-libs/blob/main/build/action.yml is on 3.x.

@dhalbert
Copy link
Contributor

It appears this problem goes away if we install the latest pre-commit with Python 3.12 and use a recent pylint. Pylint is pinned to v2.17.4 in a lot of .pre-commit-config.yaml files. I made it v3.1.0, and then everything worked on my newly updated Ubuntu 24.04 system, using latest pre-commit from pypi and letting pypi pick up everything else from pypi.

@dhalbert dhalbert reopened this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants