add initial working m5stack_stamps3 #374
Conversation
| * THE SOFTWARE. | ||
| */ | ||
|
|
||
| // #ifndef ADAFRUIT_FEATHER_ESP32S3_TFT_H_ |
There was a problem hiding this comment.
please remove those unused, and add header defie
There was a problem hiding this comment.
#ifndef M5STACK_STAMPS3_BOARD_H_
#define M5STACK_STAMPS3_BOARD_H_``
put those under the license
#endif
put this at the end
| #define USB_PRODUCT "Stamp S3" | ||
|
|
||
| #define UF2_PRODUCT_NAME USB_MANUFACTURER " " USB_PRODUCT | ||
| #define UF2_BOARD_ID "ESP32S3" |
There was a problem hiding this comment.
I have updated the board folder from cardputer to stamps3 to better match the board.
There was a problem hiding this comment.
board-id still not in correct format
There was a problem hiding this comment.
#define UF2_BOARD_ID "ESP32S3-StampS3-01"
Here is the correct board id, i didnt want to make another PR
to better fit with the actual board being used here.
|
thank you @hathach, I think this is all set now, please let me know if I missed anything. |
|
@jamesjnadeau In leu of making another PR I commented the fixes for the open changes |
|
@hathach this should now be fixed, thanks @panguin6010 for the help! |
Checklist
By completing this PR sufficiently, you help us to review this Pull Request quicker and also help improve the quality of Release Notes
UF2_BOARD_IDin your board.h follow correct format from uf2 specsThis checklist items that are not applicable to your PR can be deleted.
Description of Change
Adding setup for m5 stack stamp s3