fix double tap issue #181
Merged
fix double tap issue #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ok great work! |
|
Well done!!!! Can you wait on 0.8.0 for 10 mins while I do a PR for my new S3 boards please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix double tap issue, fix #176 . Root cause:
gpio_ll_set_level()is used in version 0.7.0 since S3 gpio rom does not havegpio_output_set_high(), unlike rom API, gpio_ll needs to explicitly enable output first.@ladyada while working on this issue, I figured out that
esp_rom_gpio_pad_select_gpio()can also be used to get JTAG pin working as double tap pin. Therefore there is no restriction on JTAG pin after this got merged. Please skip 0.7.0 for new S2 board, 0.8.0 will be released as soon as this is merged.