Add SparkFun Thing Plus RP2350 #9812
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just checking -- This board has wifi with cyw43? |
|
That's correct! I ran the basic WiFi test here and it worked fine. |
jepler
requested changes
Nov 16, 2024
eightycc
reviewed
Nov 16, 2024
ports/raspberrypi/boards/sparkfun_thing_plus_rp2350/mpconfigboard.mk
Outdated
Show resolved
Hide resolved
jepler
reviewed
Nov 18, 2024
There was a problem hiding this comment.
Thank you, the pin stuff looks good now. Thanks for the other clarifications as well.
As for the divisor issue, I do not see this setting being made in the pico2_w board specific files in the "develop" branch of pico-sdk:
https://github.com/raspberrypi/pico-sdk/blob/develop/src/boards/include/boards/pico2_w.h
i.e., they appear to be using the default divisor of 2 as well.
jepler
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copied parts from SparkFun Pro Micro RP2350 and Pico W. Tested on a board and all seems well.