Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CIRCUITPY_DEFAULT_WIFI_TX_POWER #9364

Merged
merged 3 commits into from
Jun 23, 2024
Merged

Conversation

bill88t
Copy link

@bill88t bill88t commented Jun 22, 2024

Alternative to #9357.
Fixes #9235.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about a CIRCUITPY_DEFAULT_WIFI_TX_POWER, so that different values can be set for different boards? I've included change suggestions.

ports/espressif/boards/lolin_c3_mini/mpconfigboard.h Outdated Show resolved Hide resolved
ports/espressif/common-hal/wifi/Radio.c Outdated Show resolved Hide resolved
ports/espressif/mpconfigport.h Outdated Show resolved Hide resolved
@bill88t
Copy link
Author

bill88t commented Jun 22, 2024

Agreed, this is much better. I'll test tomorrow, thanks!

@bill88t bill88t changed the title CIRCUITPY_REDUCE_TX_POWER CIRCUITPY_DEFAULT_WIFI_TX_POWER Jun 23, 2024
@bill88t
Copy link
Author

bill88t commented Jun 23, 2024

If we wanted to keep the check, fabs(20 - default) > 0.1 would be the way, but it's not really needed.

Tested on cardputer and supertiny.

@dhalbert dhalbert merged commit bdabba8 into adafruit:main Jun 23, 2024
203 checks passed
@bill88t bill88t deleted the sup_wemos_lowpow branch June 23, 2024 16:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wemos C3 Mini should pre-set tx_power to 8.5
2 participants