update LED_BUILTIN for matrixportal_m4 #270
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was having some problems with my Matrix Portal M4 project and I added some debug code to set the LED, but it didn't work. I loaded the Arduino example LED blink sketch, but that didn't work either.
It looks like originally the Matrix Portal M4 was not going to have an LED and then later one was added, but the value of LED_BUILTIN was not updated. According to variant.cpp it should be 13 (PORTA 14), but LED_BUILTIN was left using the old value 47 (used to be PORTA 15, disconnected on the schematic) which is now labeled as LIS IRQ (PORTA 27). With these changes, my LED is blinking.