Stop blinding status lights #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tyeth
force-pushed
the
status_led_brightness
branch
from
4d33227 to
53ca349
Compare
brentru
requested changes
Dec 19, 2024
| // check it casts to float and support user specifying 0.0f which is | ||
| // default, by using the |operator instead of .as | ||
| // https://arduinojson.org/v7/api/jsonvariant/or/ | ||
| if ((doc["status_pixel_brightness"] | -1.0f) != -1.0f) { |
There was a problem hiding this comment.
Set to match the default, https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/blob/main/src/provisioning/tinyusb/Wippersnapper_FS.cpp#L328 so | 0.2f
| if (doc["status_pixel_brightness"]){ | ||
| // check it casts to float and support user specifying 0.0f which is default, | ||
| // by using the |operator instead of .as https://arduinojson.org/v7/api/jsonvariant/or/ | ||
| if ((doc["status_pixel_brightness"] | -1.0f) != -1.0f) { |
There was a problem hiding this comment.
Set to match the default, https://github.com/adafruit/Adafruit_Wippersnapper_Arduino/blob/main/src/provisioning/tinyusb/Wippersnapper_FS.cpp#L328 so | 0.2f
tyeth
force-pushed
the
status_led_brightness
branch
from
1a0c46d to
9ddb120
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Neopixel brightness has been ignored for a while, and I've been meaning to take a look, but I'm only reminded in serious testing phases. This resolves the issue (only tested with tinyusb devices, but littlefs will be identical)