Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fsHalt message improvements #570

Merged
merged 1 commit into from
Apr 19, 2024
Merged

fsHalt message improvements #570

merged 1 commit into from
Apr 19, 2024

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Apr 16, 2024

Closes #545

@tyeth tyeth force-pushed the deviceid_generation_failure_fshalt branch from db4724d to c7ea0f3 Compare April 16, 2024 18:49
@tyeth
Copy link
Contributor Author

tyeth commented Apr 16, 2024

Needs to be rebased once #572 is merged

@tyeth tyeth force-pushed the deviceid_generation_failure_fshalt branch from c7ea0f3 to 8298485 Compare April 16, 2024 20:35
@tyeth tyeth requested a review from brentru April 19, 2024 00:23
@tyeth
Copy link
Contributor Author

tyeth commented Apr 19, 2024 •
edited
Loading

This ones ready for review too @brentru

brentru
brentru approved these changes Apr 19, 2024
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Replacing the (for/delay) with haltError() calls is a good idea.

@tyeth tyeth merged commit 9bf5dc4 into main Apr 19, 2024
32 checks passed
@tyeth tyeth deleted the deviceid_generation_failure_fshalt branch April 19, 2024 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

RED LIGHT: Improve Error Messages in early failure situations and possibly compile time:
2 participants
@tyeth @brentru