Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SGP40 #487

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Add SGP40 #487

merged 3 commits into from
Sep 19, 2023

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Sep 8, 2023

@brentru
Takes 30minutes to start registering VOC_Index, expected but mental note to put a big warning in the wippersnapper learn guide page

CzuAbluwar
hSdjUh0YrF

@brentru
Copy link
Member

brentru commented Sep 8, 2023

@tyeth This is failing on CI

@tyeth
Copy link
Contributor Author

tyeth commented Sep 8, 2023

@brentru everything will fail, Drazzy.com is returning connection refused as of a few hours ago. See SpenceKonde/ATTinyCore#803

I wonder if we sponser them some CI help, there is mention of them being up for SSL setup assistance or CI help, but they don't know servers as well as embedded. We could fix their CI to host the board package on GH-pages. There's also the megaTinyCore repo. and the https://github.com/SpenceKonde/ReleaseScripts seems to contain the build logic at present

@tyeth
Copy link
Contributor Author

tyeth commented Sep 13, 2023

@brentru ready for review

@brentru
Copy link
Member

brentru commented Sep 13, 2023

Merged #488, could you merge in this workflow and re-run?

Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tyeth LGTM!

@tyeth tyeth merged commit f146157 into adafruit:main Sep 19, 2023
@tyeth tyeth deleted the add-SGP40 branch September 19, 2023 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants