Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SHT30 Alternative Packaging products #481

Merged
merged 2 commits into from
Sep 5, 2023
Merged

Add SHT30 Alternative Packaging products #481

merged 2 commits into from
Sep 5, 2023

Conversation

tyeth
Copy link
Contributor

@tyeth tyeth commented Sep 1, 2023

Adds aliases for the sht30_shell + sht30_weatherproof

@tyeth tyeth marked this pull request as draft September 1, 2023 15:55
@tyeth
Copy link
Contributor Author

tyeth commented Sep 1, 2023 •
edited
Loading

Blocked by I2C Decode Error, sensor name is too long (15character max)
https://github.com/adafruit/Wippersnapper_Protobuf/blob/master/proto/wippersnapper/i2c/v1/i2c.proto#L94-L115

@tyeth tyeth mentioned this pull request Sep 1, 2023
Merged
@tyeth tyeth marked this pull request as ready for review September 1, 2023 16:41
brentru
brentru approved these changes Sep 1, 2023
View reviewed changes
Copy link
Member

@brentru brentru left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks OK and matches component rename

@brentru
Copy link
Member

brentru commented Sep 1, 2023

Can merge when ready

@tyeth tyeth merged commit 3b04089 into adafruit:main Sep 5, 2023
@tyeth tyeth deleted the add-SHT30-Variants branch September 5, 2023 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brentru brentru brentru approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tyeth @brentru