Fix driver for BME680 + BME688 using alt address #479
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@brentru minor issue discovered while sensoring up the banana plant. Default address is 0x77 |
brentru
approved these changes
Sep 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During the mega-testing after resolving decode issues, I've been struggling to get a BME688 online. It was using the alt address, and about a dozen things on the bus.
I moved it to a solo qtpyS2 and still an issue. Spotted the driver isn't passing the address.
I missed this when adding the BME688 as an alias of the BME680. I think I must have failed to connect both at the same time as in my original testing method. Mental note to still connect+screenshot both even if screenshots need one on default address.