Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issues with strandtest_nodelay() #386

Merged
merged 2 commits into from
May 2, 2024
Merged

Conversation

hathach
Copy link
Member

@hathach hathach commented Apr 26, 2024

issue is reported by user in https://forums.adafruit.com/viewtopic.php?t=209836

  • fix slower swipe, 5s timeout before next to new pattern
  • fix The wipes also do not start at the same pixel: pixelCurrent reset to 0 when move to new pattern
  • fix theaterChase() incorrect behavior (with only 2 first pixel fast blinking)

there is more issues but it require a bit of reword since theaterChase() does not seems to be equivalent to the one in delay version of strandtest
TODO: draft PR, will mark as ready once fixed all the issues later.

@hathach hathach marked this pull request as ready for review May 2, 2024 04:05
@hathach hathach requested review from ladyada and a team May 2, 2024 04:08
@ladyada ladyada merged commit 680e5b7 into master May 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants