Fix issue #6 and add tca8418_simpletest.py #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great! So are you thinking of leaving both, or do you intend to delete the duplicate now that you know this looks good? |
|
I'll remove it, just wanted to be sure before I start deleting things. I'll go update the PR now |
adafruit-adabot
added a commit
to adafruit/Adafruit_CircuitPython_Bundle
that referenced
this pull request
Oct 5, 2022
Updating https://github.com/adafruit/Adafruit_CircuitPython_Fingerprint to 2.2.10 from 2.2.9: > Merge pull request adafruit/Adafruit_CircuitPython_Fingerprint#49 from prcutler/issue32 Updating https://github.com/adafruit/Adafruit_CircuitPython_LTR329_LTR303 to 2.0.0 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_LTR329_LTR303#3 from caternuson/iss2 Updating https://github.com/adafruit/Adafruit_CircuitPython_SI1145 to 1.1.5 from 1.1.4: > Merge pull request adafruit/Adafruit_CircuitPython_SI1145#15 from DeadSix27/patch-1 Updating https://github.com/adafruit/Adafruit_CircuitPython_TCA8418 to 1.0.5 from 1.0.4: > Merge pull request adafruit/Adafruit_CircuitPython_TCA8418#10 from prcutler/issue6 Updating https://github.com/adafruit/Adafruit_CircuitPython_Display_Shapes to 2.5.6 from 2.5.5: > Merge pull request adafruit/Adafruit_CircuitPython_Display_Shapes#58 from isacben/add-type-annotations-to-docstrings Updating https://github.com/adafruit/Adafruit_CircuitPython_NTP to 3.0.8 from 3.0.7: > Merge pull request adafruit/Adafruit_CircuitPython_NTP#26 from prcutler/issue25 Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA: > Added the following libraries: Adafruit_CircuitPython_BLE_File_Transfer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #6 and add tca8418_simpletest.py.
Note - I did not rename the file as noted in the issue, I've added the new file to make sure it's correct and if so, then the tca8418_gpioblink.py file can be removed.