Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Annotations #17

Merged
merged 2 commits into from
Jan 16, 2023
Merged

Fix Annotations #17

merged 2 commits into from
Jan 16, 2023

Conversation

tcfranks
Copy link
Contributor

resolves #11
submitted for review / comment

@tannewt tannewt requested a review from a team December 15, 2022 17:21
tekktrik
tekktrik requested changes Jan 6, 2023
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one's a little bit more complex in the voc_algorithm.py file, so here's feedback for part 1 while I look at that next.

adafruit_sgp40/__init__.py Outdated Show resolved Hide resolved
adafruit_sgp40/__init__.py Show resolved Hide resolved
adafruit_sgp40/__init__.py Show resolved Hide resolved
@tcfranks
Copy link
Contributor Author

resubmitted init.py with suggested change

tekktrik
tekktrik approved these changes Jan 16, 2023
View reviewed changes
Copy link
Member

@tekktrik tekktrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@tekktrik tekktrik merged commit f3c7e47 into adafruit:main Jan 16, 2023
adafruit-adabot added a commit to adafruit/Adafruit_CircuitPython_Bundle that referenced this pull request Jan 16, 2023
@adafruit-adabot
Automated update by Adabot (adafruit/adabot@85a9103)
7e1c0e5 
Updating https://github.com/adafruit/Adafruit_CircuitPython_FONA to 2.1.15 from 2.1.14:
  > Merge pull request adafruit/Adafruit_CircuitPython_FONA#25 from ric-sapasap/bugfix/issue-24
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_PCA9685 to 3.4.7 from 3.4.6:
  > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#47 from tcfranks/main
  > Merge pull request adafruit/Adafruit_CircuitPython_PCA9685#46 from tekktrik/dev/update-pylint
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_SGP40 to 1.3.11 from 1.3.10:
  > Merge pull request adafruit/Adafruit_CircuitPython_SGP40#17 from tcfranks/main
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_PortalBase to 1.14.6 from 1.14.5:
  > Merge pull request adafruit/Adafruit_CircuitPython_PortalBase#88 from Neradoc/documentation-add-text-index
  > Add .venv to .gitignore

Updating https://github.com/adafruit/Adafruit_CircuitPython_Bundle/circuitpython_library_list.md to NA from NA:
  > Updated download stats for the libraries
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tekktrik tekktrik tekktrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing Type Annotations
2 participants
@tcfranks @tekktrik