Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

guard against invalid response #38

Closed
wants to merge 2 commits into from
Closed

guard against invalid response #38

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2495e3
guard against invalid response
tedder Jul 16, 2024
a923944
PR feedback, test zero
tedder Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions adafruit_ntp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,6 +102,10 @@ def datetime(self) -> time.struct_time:
self.next_sync = destination + cache_offset * 1_000_000_000
seconds = struct.unpack_from("!I", self._packet, offset=PACKET_SIZE - 8)[0]

# value should always be larger; giving a small buffer to handle jitter.
if seconds == 0:
raise ArithmeticError("ntp value is invalid (empty)")

self._monotonic_start = (
seconds
+ self._tz_offset
Expand Down
Loading